refactor(editor): rebuild diff viewer around code editor kernels - #954
Merged
Conversation
bzy-debug
force-pushed
the
codex/diff-viewer-alignment-overview
branch
from
August 21, 2026 02:25
288921a to
541e7cb
Compare
bzy-debug
force-pushed
the
codex/diff-viewer-alignment-overview
branch
from
August 21, 2026 08:23
b227e81 to
943df0d
Compare
bzy-debug
marked this pull request as ready for review
August 21, 2026 08:24
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 943df0d089
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bzy-debug
force-pushed
the
codex/diff-viewer-alignment-overview
branch
from
August 21, 2026 09:56
20c206d to
c75109e
Compare
added 8 commits
August 21, 2026 18:04
Extract VS Code-shaped definition and references actions plus a per-surface references controller. Host Markdown Peek in an overlay with an injected CodeEditor preview and cover cancellation, resolver leases, command semantics, and model replacement.
bzy-debug
force-pushed
the
codex/diff-viewer-alignment-overview
branch
from
August 21, 2026 10:04
c75109e to
1954b10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Viewer-basedDiffViewercoordinator with a first-classDiffEditorWidgetthat owns two code-onlyCodeEditorWidgetkernels and one sharedDiffEditorViewModelMarkdownViewersurface and make desktop/embedded hosts choose code, Markdown, or diff presentation explicitlyDocumentDiffProvidercontract, keep Core as the default provider, expose MoonDiff as optional host-owned Token/Tree modes, and remove fake moves/timeout compatibilityDiffViewer/Unified implementations and add an architecture gate preventingDiffEditorfrom depending on the publicViewersurfaceBreaking changes
DiffVieweris replaced byDiffEditor; Unified terminology is replaced by InlineVieweris code-only; Markdown routing is host-owned throughMarkdownViewerValidation
just checkjust test— native 3182, JS 3043, cram 27just buildjust editor-test— wasm 1058, JS 1798, native 1186just editor-test-browser— 86 passedSeekMoon.appRebased onto
mainat84bfd310before publication.