refactor(desktop): adopt Proton PR #129 runtime - #958
Draft
Milky2018 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dc9a107282eedb2c5329dba15fbe7d4d8bbf5ec6and resolve its source modules from the root workspacelibproton,.proton/runtime.json, andPROTON_NATIVE_DISTcontractValidation
moon -C desktop check --target native --diagnostic-limit 200moon -C desktop test package/internal/packaging --target native(11/11)moon -C desktop test package/macos --target native(5/5)moon -C desktop run --target native package/macos -- --release --target app --no-opencodesign --verify --deep --strict --verbose=2 desktop/dist/SeekMoon.applibproton.dylib,proton.dll, orproton.libSeekMoon.app, confirmed it remained running, and terminated it cleanlyjust buildCurrent integration gate results
just checkcurrently stops on 54implicit_impl_as_methodwarnings promoted by--deny-warn; all reported locations are outside this diffjust testcurrently reports 3504/3513 passing; the 9 failures are inagent_tooledit, multi-edit, remove, and write tests where temporary Moon workspace/check output enters the expected result, outside the Proton and packaging paths touched hereDependency
This draft intentionally tracks the unpublished source and contracts from moonbit-community/proton#129.