Skip to content

fix(desktop): integrate macOS titlebar controls - #960

Draft
tonyfettes wants to merge 1 commit into
mainfrom
codex/macos-titlebar-overlay
Draft

fix(desktop): integrate macOS titlebar controls#960
tonyfettes wants to merge 1 commit into
mainfrom
codex/macos-titlebar-overlay

Conversation

@tonyfettes

Copy link
Copy Markdown
Contributor

Summary

  • use Proton's titlebar overlay on macOS so SeekMoon paints the native window-control area
  • reserve and align the traffic lights in both packaged and development HTML entries with a 36px header and an 80px leading inset
  • add a packaging regression test for the native platform marker while leaving the browser console unchanged

Validation

  • moon -C desktop check . --target native (passes with 54 existing warnings)
  • moon -C desktop check frontend --target js (passes with 70 existing warnings)
  • moon -C desktop test package/internal/packaging --target native (16/16 passed)
  • moon -C desktop info
  • moon -C desktop fmt
  • git diff --check
  • visually verified through user-provided macOS development screenshots

@tonyfettes
tonyfettes marked this pull request as ready for review August 21, 2026 08:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2da7677d91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/styles/base.css
Comment on lines +254 to +257
:root.macos-titlebar-overlay
.app.sidebar-collapsed
.content.panel-expanded
.editor-tabsbar {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reserve traffic-light space for the narrow file panel

When a macOS window is resized to 760px or narrower and the file panel is opened, responsive.css makes every .content.panel-open .editor fixed at inset: 0 and hides the expand control, while this inset only applies to the normally-false panel-expanded state. The first editor tabs therefore retain their 12px padding and render directly underneath the native traffic lights; apply the leading inset to the narrow full-screen panel-open state as well.

Useful? React with 👍 / 👎.

@tonyfettes
tonyfettes marked this pull request as draft August 21, 2026 12:38
@tonyfettes

Copy link
Copy Markdown
Contributor Author

This sometimes crashes the application on exit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant