fix(desktop): integrate macOS titlebar controls - #960
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2da7677d91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| :root.macos-titlebar-overlay | ||
| .app.sidebar-collapsed | ||
| .content.panel-expanded | ||
| .editor-tabsbar { |
There was a problem hiding this comment.
Reserve traffic-light space for the narrow file panel
When a macOS window is resized to 760px or narrower and the file panel is opened, responsive.css makes every .content.panel-open .editor fixed at inset: 0 and hides the expand control, while this inset only applies to the normally-false panel-expanded state. The first editor tabs therefore retain their 12px padding and render directly underneath the native traffic lights; apply the leading inset to the narrow full-screen panel-open state as well.
Useful? React with 👍 / 👎.
|
This sometimes crashes the application on exit. |
Summary
Validation
moon -C desktop check . --target native(passes with 54 existing warnings)moon -C desktop check frontend --target js(passes with 70 existing warnings)moon -C desktop test package/internal/packaging --target native(16/16 passed)moon -C desktop infomoon -C desktop fmtgit diff --check