Skip to content

feat: add configurable minOEVFee to ChainlinkFeedOEVWrapper #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sertug17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add configurable minOEVFee to ChainlinkFeedOEVWrapper #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/oracles/ChainlinkFeedOEVWrapper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ contract ChainlinkFeedOEVWrapper is AggregatorV3Interface, Ownable {
/// @param newMaxRoundDelay The new maximum round delay
event NewMaxRoundDelay(uint8 oldMaxRoundDelay, uint8 newMaxRoundDelay);

/// @notice Emitted when the minimum OEV fee is changed
/// @param oldFee The old minimum fee
/// @param newFee The new minimum fee
event MinOEVFeeChanged(uint256 oldFee, uint256 newFee);

/// @notice The original Chainlink price feed contract
AggregatorV3Interface public immutable originalFeed;

Expand All @@ -48,6 +53,11 @@ contract ChainlinkFeedOEVWrapper is AggregatorV3Interface, Ownable {
/// @dev Represented as a percentage
uint8 public feeMultiplier;

/// @notice The minimum fee for an early price update, in wei
/// @dev Prevents zero-cost OEV capture on low-gas chains. Set by owner.
/// A value of 0 means no minimum (backwards compatible).
uint256 public minOEVFee;

/// @notice The maximum number of times to decrement the round before falling back to latest price
uint8 public maxDecrements;

Expand Down Expand Up @@ -201,7 +211,8 @@ contract ChainlinkFeedOEVWrapper is AggregatorV3Interface, Ownable {
/// @dev Requires payment of a fee based on gas price and fee multiplier
function updatePriceEarly() external payable returns (uint256) {
require(
msg.value >= (tx.gasprice - block.basefee) * uint256(feeMultiplier),
msg.value >= (tx.gasprice - block.basefee) * uint256(feeMultiplier) &&
msg.value >= minOEVFee,
"ChainlinkOEVWrapper: Insufficient tax"
);

Expand Down Expand Up @@ -256,6 +267,16 @@ contract ChainlinkFeedOEVWrapper is AggregatorV3Interface, Ownable {
emit FeeMultiplierChanged(oldMultiplier, newMultiplier);
}

/// @notice Set the minimum OEV fee for early price updates
/// @param _minOEVFee The new minimum fee in wei
/// @dev Only callable by the contract owner. Set to 0 to disable minimum.
function setMinOEVFee(uint256 _minOEVFee) external onlyOwner {
uint256 oldFee = minOEVFee;
minOEVFee = _minOEVFee;

emit MinOEVFeeChanged(oldFee, _minOEVFee);
}

/// @notice Set the maximum number of decrements before falling back to latest price
/// @param _maxDecrements The new maximum number of decrements
function setMaxDecrements(uint8 _maxDecrements) external onlyOwner {
Expand Down