Skip to content

[codex] Add on-prem Ollama regression tests#762

Draft
cazzek wants to merge 1 commit into
moorcheh-ai:mainfrom
cazzek:codex/add-onprem-ollama-regression-tests
Draft

[codex] Add on-prem Ollama regression tests#762
cazzek wants to merge 1 commit into
moorcheh-ai:mainfrom
cazzek:codex/add-onprem-ollama-regression-tests

Conversation

@cazzek

@cazzek cazzek commented Jun 20, 2026

Copy link
Copy Markdown

Summary

  • add regression coverage for the native host Ollama path fixed in Fix/onprem host ollama pull #758
  • verify reachable host Ollama uses the HTTP pull helper without touching Docker
  • verify unreachable host Ollama falls back to the bundled container
  • verify on-prem setup routes both Quick Setup models through the shared pull helper

Why

Issue #753 showed that on-prem setup could detect and reuse a healthy native Ollama instance, then still try to pull models through a Docker container that did not exist. The production fix is already present on main via #758, but the corrected dispatch behavior had no regression coverage.

Impact

Tests only. No runtime behavior changes.

Validation

  • pytest tests/test_onprem_ollama.py -vv — 3 passed
  • HOME=/tmp/memanto-test-home pytest --ignore=tests/test_e2e.py — 138 passed
  • ruff check . — passed
  • git diff --check — passed

Closes regression coverage gap for #753.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e719ece2-2a40-470d-a94c-f88ae2097f5c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cazzek cazzek force-pushed the codex/add-onprem-ollama-regression-tests branch from 75774d6 to 47e99d0 Compare June 20, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant