Add missing pytest plugins to all extra#773
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo test dependencies, Test Dependency Additions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Aligns the .[all] development extra with the repository’s pytest configuration so a clean pip install -e ".[all]" environment can run tests without failing during pytest configuration/collection (notably for async tests and timeout config).
Changes:
- Add
pytest-asyncio>=0.21.0to thealloptional dependency extra. - Add
pytest-timeout>=2.1.0to thealloptional dependency extra.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related to #770
Flaw summary
The advertised development setup path
pip install -e ".[all]"does not install all pytest plugins required by the repository's own pytest configuration and async tests. In a clean environment, pytest stops during configuration/collection before any tests can run becausepytest-asyncioandpytest-timeoutare absent.This is a setup/UX roadblock for the bug challenge because contributors following the package extra cannot reproduce or validate test cases locally without discovering and installing hidden test dependencies manually.
Reproduction
From a clean checkout with Python 3.12:
Before this change, pytest fails before running tests with configuration/plugin errors such as:
'asyncio' not found in markers configuration optionUnknown config option: timeoutFix
Add the missing pytest plugins to the
alloptional dependency extra so the documented all-in development install matches the repository's test configuration:pytest-asyncio>=0.21.0pytest-timeout>=2.1.0These were already present in the
devdependency group andtests/requirements.txt; this change keeps.[all]consistent with those paths.Verification
Summary by CodeRabbit