Skip to content

build: run Go tests on Windows #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build: run Go tests on Windows #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee33241
build: run Go tests on Windows
adamdecaf Jun 30, 2023
f814e3a
test: fix variable/EBCDIC windows tests
adamdecaf Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ build-webui:
.PHONY: check
check:
ifeq ($(OS),Windows_NT)
@echo "Skipping checks on Windows, currently unsupported."
go test ./...
else
@wget -O lint-project.sh https://raw.githubusercontent.com/moov-io/infra/master/go/lint-project.sh
@chmod +x ./lint-project.sh
Expand Down
10 changes: 4 additions & 6 deletions reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import (
"strconv"
"strings"
"testing"

"github.com/stretchr/testify/require"
)

// TestICLFileRead validates reading an ICL file
Expand Down Expand Up @@ -103,9 +105,7 @@ func TestICL_ReadVariableLineLengthOption(t *testing.T) {
if err != nil {
t.Errorf("Issue loading validation criteria: %+v \n", err)
}
if !bytes.Equal(actual, expected) {
t.Errorf("Read file does not match expected JSON")
}
require.Equal(t, expected, actual)
}

func TestICL_EBCDICEncodingOption(t *testing.T) {
Expand Down Expand Up @@ -134,9 +134,7 @@ func TestICL_EBCDICEncodingOption(t *testing.T) {
if err != nil {
t.Errorf("Issue loading validation criteria: %+v \n", err)
}
if !bytes.Equal(actual, expected) {
t.Errorf("Read file does not match expected JSON")
}
require.Equal(t, expected, actual)
}

// TestRecordTypeUnknown validates record type unknown
Expand Down