Optimised page file opening #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the 200ms timeout on creating subscriptions is sometimes not enough on the GitHub CI environment: Do you want me to create a PR to increase it to 300? |
andsel
requested changes
May 24, 2024
broker/src/main/java/io/moquette/broker/unsafequeues/PagedFilesAllocator.java
Outdated
Show resolved
Hide resolved
hylkevds
force-pushed
the
fix_optimisePageFileReuse
branch
2 times, most recently
from
9ad8d53 to
2bd3c36
Compare
Instead of mapping the entire page file every time a segment is re-used, we map the page file once, and re-use the mapped buffer for each segment. The cache uses WeakReferences to ensure that a page file that is no longer used does not stay mapped.
hylkevds
force-pushed
the
fix_optimisePageFileReuse
branch
from
2bd3c36 to
f0fa762
Compare
|
Thank's @hylkevds for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mapping the entire page file every time a segment is re-used, we map the page file once, and re-use the mapped buffer for each segment.
The cache uses WeakReferences to ensure that a page file that is no longer used does not stay mapped.