Simplify ZipShortest implementation
#904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 92.38% 92.48% +0.09%
==========================================
Files 110 110
Lines 3442 3460 +18
Branches 1021 1025 +4
==========================================
+ Hits 3180 3200 +20
+ Misses 200 198 -2
Partials 62 62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Duplicate in the sense that both separate the implementations of the three zip functions, yes. However, #715 uses T4 to generate separate implementations of each method for argument count 2-4. #715 and #904 have essentially the same implementation, with some variances on how the implementation is written. |
|
Closing in favor of PR #715. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various Zip* methods currently share implementation in
.ZipImpl(). However, the code is simpler for each one when they are written separately; that is, in this case, the variances are more than the commonality. As such, we should allow each method to be implemented separately.This PR updates the implementation of
ZipShortestto be done separately from.ZipImpl().