fix: reject zero scale factor#118
Closed
prd-carapulse[bot] wants to merge 3 commits into
Closed
Conversation
Reject zero scale factors and add the Certora scaleFactorCannotBeZero proof.
Require the harness deployment to succeed before asserting on the returned scale factor.
Refactor scale factor computation into an internal helper and make the Certora harness verify the exact successful helper computation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCALE_FACTORvalues after the constructor's integer division.scaleFactorCannotBeZerofor every successfulMorphoChainlinkOracleV2deployment.Request Context
morpho-org/morpho-blue-oraclesto prove with Certora that the scale factor cannot be zero.Test Plan
forge fmt --checkforge build --forceforge build --contracts certora/helpers/MorphoChainlinkOracleV2Harness.sol --forceforge test --match-path test/MorphoChainlinkOracleV2ScaleFactorTest.sol -vvvcertoraCVLFormatter certora/specs/MorphoChainlinkOracleV2.specjq < certora/confs/MorphoChainlinkOracleV2.confcertoraRun certora/confs/MorphoChainlinkOracleV2.conf --compilation_steps_onlyCERTORAKEYRequested by: <@U02NB58F6R3>