Update AWS OFI NCCL version #3844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajachan
reviewed
May 5, 2025
willgleich
approved these changes
May 5, 2025
There was a problem hiding this comment.
lgtm thanks for the info regarding the EFA INSTALLER @rajachan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates to the latest OFI NCCL version
WIP retesting after comment from AWS that we don't need to separately install the ofi nccl plugin
Before:
llama70b-8192-ofi-old-image-aws-1-0g5LefAfter:
llama70b-8192-ofi-new-vendored-aws-2-a1gQZ4throughput is slightly higher on the new image.
Note: we were originally going to go back to using
latestfor the EFA installer version, but 1.40 is producing an installation an error, so I'm pinning that to 1.39 (previous version). This is a known issue here with the debug install, so should be fixed soonish.