Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Docker-based build workflow for the documentation, streamlining CI jobs and separating PDF and HTML builds. It adds a dedicated Docker image for LaTeX builds, restructures the GitHub Actions workflows to use this image, and improves artifact handling between jobs. These changes make the documentation build process more reliable and modular, especially for PDF generation.
CI Workflow Improvements:
.github/workflows/docker-docs.ymlto build and publish adocs-buildDocker image to GHCR on changes todocs/Dockerfileor via manual dispatch..github/workflows/docs.ymlto split jobs intobuild-pdf(using the Docker image) andbuild-html, with improved artifact upload/download for the PDF. The publish job now depends onbuild-html. [1] [2] [3]Docker Image Enhancements:
docs/Dockerfileto add Open Container Initiative labels describing the image and its source, clarifying its purpose for LaTeX builds.Makefile and Build Process Updates:
DOCKER_IMAGEvariable indocs/Makefileto default to the published GHCR image, and updated thedocker-pdftarget to pull the image instead of building locally, with instructions for overriding. [1] [2]