chore: fix go lint

Signed-off-by: Manfred Touron <[email protected]>

.golangci.yml

@@ -7,8 +7,6 @@ run:
     - ".*\\.gen\\.go"
 
 linters-settings:
-  golint:
-    min-confidence: 0
   maligned:
     suggest-new: true
   goconst:
@@ -40,22 +38,23 @@ linters:
     - gofmt
     - gofumpt
     - goimports
-    - golint
+    #- golint
     - gomnd
     - gomodguard
     - gosec
     - gosimple
     - govet
     - ineffassign
-    - interfacer
+    #- interfacer
     #- maligned
     - misspell
     - nakedret
     - nestif
     - noctx
     - nolintlint
     - prealloc
-    - scopelint
+    - revive
+    - exportloopref
     - sqlclosecheck
     - staticcheck
     - structcheck

internal/dvserver/server.go

@@ -218,7 +218,8 @@ func New(ctx context.Context, h *cayley.Handle, schema *schema.Config, opts Opts
 		}
 		svc.httpListenerAddr = listener.Addr().String()
 		srv := http.Server{
-			Handler: r,
+			ReadHeaderTimeout: 2 * time.Second, // nolint:gomnd
+			Handler:           r,
 		}
 		svc.workers.Add(func() error {
 			httpLogger.Debug("starting HTTP server", zap.String("bind", opts.HTTPBind))

internal/githubprovider/model.go

@@ -91,7 +91,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error {
 
 	// assignees
 	for _, assignee := range input.Assignees {
-		assigneeRet, err := fromUser(batch, assignee) // nolint:typecheck // false-positive?
+		assigneeRet, err := fromUser(batch, assignee)
 		if err != nil {
 			return fmt.Errorf("from user: %w", err)
 		}
@@ -106,7 +106,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error {
 
 	// labels
 	for _, label := range input.Labels {
-		labelRet, err := fromLabel(batch, label) // nolint:typecheck // false-positive?
+		labelRet, err := fromLabel(batch, label)
 		if err != nil {
 			return fmt.Errorf("from label: %w", err)
 		}