Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set screenshots list overflow to auto #13425

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

anewuser
Copy link
Contributor

@anewuser anewuser commented Jan 30, 2025

Fixes #15319.

Change overflow-x from scroll to auto.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (47e0718) to head (7d88514).
Report is 248 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13425   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         267      267           
  Lines       10614    10614           
  Branches     3236     3236           
=======================================
  Hits        10432    10432           
  Misses        169      169           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diox diox requested review from a team and KevinMind and removed request for a team February 17, 2025 15:09
@KevinMind
Copy link
Contributor

@anewuser could you add a before and after screenshot of the fix? Or perhaps a different addon to test the bug on production as the linked addon is 404ing for me.

@KevinMind
Copy link
Contributor

I'm not actually able to reproduce this on production. Tried on firefox and chrome.

Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to verify on mac, but the change is relatively harmless so LGTM 🚢

@anewuser
Copy link
Contributor Author

@KevinMind I've uploaded videos here: #issuecomment-2625711316. This affects all download pages with fewer than three screenshots. You can use a service like Browserling to test websites on a Windows VM:

https://www.browserling.com/browse/win10/firefox128/addons.mozilla.org/firefox/addon/youtube-no-translation/

@KevinMind KevinMind merged commit f4033fe into mozilla:master Apr 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unnecessary scrollbar under screenshots
2 participants