-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read Promoted Group Information Via Models #23082
Read Promoted Group Information Via Models #23082
Conversation
ef58b87
to
d3fe342
Compare
d497061
to
4928d11
Compare
ac814ce
to
047c447
Compare
047c447
to
c24f1fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions and wondering if it would be possible to split this into 2 PRs. This PR should be able to move the "read" operations from PromotedAddon
to PromotedAddonPromotion
without otherwise changing much of anything like function signatures.
Then we would migrate the "write" operations from PromotedAddon
to PromotedAddonPromotion
.
Finally, you can modify the method signatures to support multiple promoted groups.
I think it might be easier/safer to get this out in these smaller PRs that focus on one specific part.
I think its at the point where splitting it further would make things more difficult. All the changes here are pretty interconnected at this point, the signals part was the only part I could manage to split off (and even then it wasn't much). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a strong-ish opinion about the API changes. Modifying the signature and source of truth from the Promotion to the Group is not really what I thought we were going to do and I think it was better the way it was.
Let's discuss on a call and figure out what to do and move from there.
7683eea
to
e1370cc
Compare
94ef792
to
879e0c2
Compare
…o #15350-read-promoted-models
…o #15350-read-promoted-models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, fix the tests and make sure to notify in the next release notes that we need QA to do a full test of promoted addon behavior.
208a168
to
761bfb1
Compare
72e4c6f
to
57984c3
Compare
Fixes: mozilla/addons#15350
Description
Reads promoted group information via models.
Testing
Promoted add-on behaviour should be largely the same (as this PR is only switching the read behaviour, and not explicitly allowing multiple promoted addons.), except:
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.