Bump Node.js to 20.x #23139
Merged
Bump Node.js to 20.x #23139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
reviewed
Mar 5, 2025
| @@ -1,2 +1,2 @@ | |||
| deb https://deb.nodesource.com/node_18.x nodistro main | |||
| deb-src https://deb.nodesource.com/node_18.x nodistro main | |||
| deb https://deb.nodesource.com/node_20.x nodistro main | |||
There was a problem hiding this comment.
Do we need to update the gpg key?
3.139 Err:4 http://deb.debian.org/debian bookworm-updates InRelease
3.139 Unknown error executing apt-key
3.206 Get:8 https://deb.nodesource.com/node_20.x nodistro/main amd64 Packages [10.6 kB]
3.758 Get:9 http://deb.debian.org/debian-security bookworm-security/main amd64 Packages [246 kB]
3.827 Reading package lists...
4.224 W: Skipping acquire of configured file 'main/source/Sources' as repository 'https://deb.nodesource.com/node_20.x nodistro InRelease' does not seem to provide it (sources.list entry misspelt?)
4.224 W: GPG error: http://deb.debian.org/debian bookworm-updates InRelease: Unknown error executing apt-key
4.224 E: The repository 'http://deb.debian.org/debian bookworm-updates InRelease' is not signed.
------
Dockerfile:73There was a problem hiding this comment.
The GPG key is correct, it looks like a problem with the docker image (and not linked to this PR in particular - it's failing on a debian repo). I'll see if we can work around it.
I'll also remove the deb-src for node as it's useless & not working properly
There was a problem hiding this comment.
Per docker-library/python#837 (comment) this is an issue with the host running docker with that image. I am not seeing it locally or in our CI, were you seeing this on your machine ?
There was a problem hiding this comment.
Try updating docker on your host maybe ? In any case that's not caused by this PR.
KevinMind
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mozilla/addons#15266