rm TAAR service integrations

[eviljeff]

Fixes: mozilla/addons#15377

Description

Removes all TAAR integration, and attempts to rename what's left to not reference TAAR.

Context

Testing

Verify that the two endpoints in the issue return results

Checklist

• Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
• Successfully verified the change locally.
• The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
• Add before and after screenshots (Only for changes that impact the UI).
• Add or update relevant docs reflecting the changes made.

[KevinMind]

Could you add this to the addons DRF viewset in the relevant method? Just good hygiene to continually update the methods so we eventually don't have to maintain the separate api docs.

[eviljeff]

Can you link to docs explaining how to do this?

[KevinMind]

Could you link the relevant endpoints in the PR.. I don't actually see anything in the issue or the linked doc at least not obviously.

[eviljeff]

Could you link the relevant endpoints in the PR.. I don't actually see anything in the issue or the linked doc at least not obviously.

Mat linked to the docs that detail the endpoints in the comment directly preceding yours. They are:

• https://mozilla.github.io/addons-server/topics/api/v4_frozen/discovery.html#discovery-content
• https://mozilla.github.io/addons-server/topics/api/addons.html#recommendations

[KevinMind]

Could you link the relevant endpoints in the PR.. I don't actually see anything in the issue or the linked doc at least not obviously.

Mat linked to the docs that detail the endpoints in the comment directly preceding yours. They are:

* https://mozilla.github.io/addons-server/topics/api/v4_frozen/discovery.html#discovery-content

* https://mozilla.github.io/addons-server/topics/api/addons.html#recommendations

Thanks for clarifying. FWIW the confusion for me was that there are 2 links, with a total of 6 endpoints.. and it wasn't even clear that was the comment that I should have been referring to. Might have been obvious to you, but definitely wasn't to me.

[eviljeff]

Could you link the relevant endpoints in the PR.. I don't actually see anything in the issue or the linked doc at least not obviously.

Mat linked to the docs that detail the endpoints in the comment directly preceding yours. They are:

* https://mozilla.github.io/addons-server/topics/api/v4_frozen/discovery.html#discovery-content

* https://mozilla.github.io/addons-server/topics/api/addons.html#recommendations

Thanks for clarifying. FWIW the confusion for me was that there are 2 links, with a total of 6 endpoints.. and it wasn't even clear that was the comment that I should have been referring to. Might have been obvious to you, but definitely wasn't to me.

It's just two endpoints - the two directly linked to (are you counting the other endpoints in different sections on the same page? Or v3, v4, v5 * 2?). /api/v4/discovery/ and /api/v5/addons/recommendations/ are the ones that must keep working, as per the issue.

[KevinMind]

http://olympia.test/api/v4/discovery/

{"results":[],"count":0}

http://olympia.test/api/v5/addons/recommendations/?guid=@spicy-pancake

{"outcome":"curated","fallback_reason":null,"page_size":1,"page_count":1,"count":0,"next":null,"previous":null,"results":[]}

I have no idea if this is "still working" I'm getting empty responses but they are not raising. It would be helpful to have specific test criteria for this since you have context on what exactly we should be expecting? That is not only helpful for me to verify, but also for QA to verify and finally for future us to debug/reverify if there is any issue that links back to this PR.

[eviljeff]

http://olympia.test/api/v4/discovery/

{"results":[],"count":0}

http://olympia.test/api/v5/addons/recommendations/?guid=@spicy-pancake

{"outcome":"curated","fallback_reason":null,"page_size":1,"page_count":1,"count":0,"next":null,"previous":null,"results":[]}

I have no idea if this is "still working" I'm getting empty responses but they are not raising. It would be helpful to have specific test criteria for this since you have context on what exactly we should be expecting? That is not only helpful for me to verify, but also for QA to verify and finally for future us to debug/reverify if there is any issue that links back to this PR.

Ahhh, you need some extra set-up locally to replicate the state on addons-dev (and stage, prod).

• For api/v5/addons/recommendations you need to have add-ons with the hard-coded guids in RECOMMENDED - easiest way is to just change the guid values of existing public addon instances in django admin|shell
• For api/v4/discovery/ there should be some DiscoveryItem instances created in django admin