Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some reserved guids #23171

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Add some reserved guids #23171

merged 1 commit into from
Mar 17, 2025

Conversation

diox
Copy link
Member

@diox diox commented Mar 14, 2025

Fixes: mozilla/addons#15423
Fixes: mozilla/addons#15424

There was some pushback against having a wildcard in there during triage meeting so I didn't go that far.

@diox diox requested review from a team and KevinMind and removed request for a team March 14, 2025 12:26
Copy link
Contributor

@KevinMind KevinMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure what I'm looking at. Can you add some additional context?

@diox
Copy link
Member Author

diox commented Mar 17, 2025

RESERVED_ADDON_GUIDS are guids (technically guid suffixes) that regular users can't use for their add-ons on AMO. Uploading a new add-on (*) with such a guid results in an error, unless you belong to a group with the specific SystemAddon:Submit permission. (See reserved_guid_addon_submission_allowed())

This is done for various reasons, but the one we care about here is to avoid any potential conflicts with internal/synthetic add-ons that are never going to be submitted on AMO.

(*) new versions of an existing add-on are always permitted, to account for the fact that some of these guids used to be accepted in the past.

@diox diox merged commit 463ff90 into mozilla:master Mar 17, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants