-
Notifications
You must be signed in to change notification settings - Fork 541
Migrate remaining files to vite #23180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2532e22
to
d7e1ab6
Compare
6ab657a
to
6c323a3
Compare
@eviljeff CI is finally green. Ready to review/verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some random comments from a code review (I didn't read all the javascript changes - I presumed the code was functionally the same as before).
Next I'll test locally.
4131d6d
to
e56b4e5
Compare
on http://olympia.test/en-GB/developers/
on http://olympia.test/en-GB/developers/addons/
on reviewer tools: http://olympia.test/reviewers
on stats: http://olympia.test/en-US/firefox/addon/spicy-pancake/statistics/
I also tried to use the theme wizard, which uploads at the end of it, but it seems to cause some error in frontend (because all local traffic for server is routed through frontend) that ends up permanently 502'ing all requests until I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, to follow-on my comments from testing.
- the devhub landing 404s should be fixed (probably trivial)
- the devhub /addons script error should be fixed, though I couldn't establish if it actually broke anything
- I couldn't verify stats worked
- uploads didn't work from the theme wizard, but likely not a regression from this patch.
8c581e0
to
c8ca8ca
Compare
There is a pre-existing error where you end up serving stale files via nginx if the site-static directory is not empty. I believe this or some other caching issue is the reason for the js error I have verified that stats is working at least the JS part. I fixed the img paths. I was able to get the static theme flow working. I think it might be related to the same caching issue which we should have a separate issue for. |
Fixes: mozilla/addons#15
Context
The remaining pages are very tightly dependant on specific shared modules so it is easiest to migrate them all at once.
After this we can remove the non vite compilation logic and add stricter linting to remove dead code and enforce all the styling rules.
Testing
For each of these pages:
Pages
change>
Note
for
stats
make sure to click through all side bar links to ensure all permutations of the page are working, as well check various date ranges including the custom range.Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.