Remove legacy less processing

[KevinMind]

Fixes: mozilla/addons#15460

Context

We should merge this last in the chain of related PRs to remove legacy css processing as all assets will then be processed by vite.

Testing

Essentially should be able to run make up in prod or dev

make up DOCKER_TARGET=<development|production>

That is covered by CI

Checklist

• Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
• Successfully verified the change locally.
• The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
• Add before and after screenshots (Only for changes that impact the UI).
• Add or update relevant docs reflecting the changes made.

[eviljeff]

Does this need some rebasing? The title is "Remove legacy less processing" but there's a bunch of javascript changes too.

[KevinMind]

Does this need some rebasing? The title is "Remove legacy less processing" but there's a bunch of javascript changes too.

Those changes are the result of using eslint on the code. We now actually enforce linting rules and so we can autofix what hasn't been caught before. 3 commits:

• remove legacy processing
• add proper linting via eslint/prettier/knip
• fix the errors that come from step 2

I could split this into yet another pair of PRs but at this point we are approaching a chain reaction where the number of PRs will soon be greater than the number of lines changed.. I kind of want to be done with this 🙃 😩

[eviljeff]

I could split this into yet another pair of PRs but at this point we are approaching a chain reaction where the number of PRs will soon be greater than the number of lines changed.. I kind of want to be done with this 🙃 😩

I'm not saying the PR is unreviewable (though I haven’t tried yet) just that the PR title (and no description) implies a different scope than the contents of the PR.

[KevinMind]

I could split this into yet another pair of PRs but at this point we are approaching a chain reaction where the number of PRs will soon be greater than the number of lines changed.. I kind of want to be done with this 🙃 😩

I'm not saying the PR is unreviewable (though I haven’t tried yet) just that the PR title (and no description) implies a different scope than the contents of the PR.

Split it.

[KevinMind]

For posterity: reduced number of files by 7k.

before

• Build

#28 17.61 8344 static files copied to '/data/olympia/site-static'.
#28 DONE 18.0s

• Upload

succeeded 7 minutes ago in 2m 52s 

after

• Build

#28 13.27 1006 static files copied to '/data/olympia/site-static'.
#28 DONE 13.7s

• Upload

 succeeded 13 hours ago in 5m 11s