Enhance health check workflows and scripts #23190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15464
Fixes: mozilla/addons#15450
Description
Context
This is patching a few holes at once but its a nightmare to test and they all cover the originally discovered problem
Testing
Test failing healtcheck
make up
the env to ensure the waffle switch is created./scripts/health_check.py --env local --verbose --retries 0
Note
If you're feeling very adventurous you could add a high retry count and disable the waffle switch midway.. should be failures until you disable it
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.