add linter for workflows #23193
Merged
add linter for workflows #23193
+52
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
kevinmind/addons/15481
branch
3 times, most recently
from
2ab2488 to
9ba1e14
Compare
KevinMind
requested review from
eviljeff,
a team and
diox
and removed request for
eviljeff and
a team
diox
reviewed
Mar 20, 2025
KevinMind
force-pushed
the
kevinmind/addons/15481
branch
from
8923028 to
007d4dd
Compare
diox
approved these changes
Mar 21, 2025
1 task
- use specific version of actionlint - extract to command to be able to run locally
KevinMind
force-pushed
the
kevinmind/addons/15481
branch
6 times, most recently
from
6a73432 to
961d14a
Compare
KevinMind
force-pushed
the
kevinmind/addons/15481
branch
from
961d14a to
ffac9b7
Compare
KevinMind
commented
Mar 21, 2025
| n=$((splits + 1)) | ||
| matrix=$(jq -n -c --arg n "$n" '[range(1;($n|tonumber))]') | ||
|
|
||
| # validate that matrix is an array of numbers from 1 to splits + 1 |
There was a problem hiding this comment.
Turns out you need to validate json data that is used to build a matrix job, otherwise the job just doesn't run and silently fails.. 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15481
Description
Use actionlint to lint our github workflow files.
Testing
Before: failing https://github.com/mozilla/addons-server/actions/runs/13952752375/job/39056293411?pr=23193
After: passing https://github.com/mozilla/addons-server/actions/runs/13952805622/job/39056471261?pr=23193
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.