Correct PromotedGroup Approvals #23218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstinalin
force-pushed
the
#15487-correct-approval-logic
branch
from
fb90f91 to
8bfac47
Compare
KevinMind
reviewed
Mar 24, 2025
KevinMind
reviewed
Mar 24, 2025
KevinMind
reviewed
Mar 24, 2025
chrstinalin
force-pushed
the
#15487-correct-approval-logic
branch
from
89bf69f to
d4e160e
Compare
KevinMind
reviewed
Mar 24, 2025
KevinMind
reviewed
Mar 24, 2025
| @@ -123,6 +123,7 @@ def bump_addon_version(old_version): | |||
| addon = old_version.addon | |||
| old_file_obj = old_version.file | |||
| promoted_group = addon.promoted_groups(currently_approved=True) | |||
| carryover = promoted_group and any(promoted_group.listed_pre_review) | |||
There was a problem hiding this comment.
Is there a tangible benefit here? If not, just remove the diff.
There was a problem hiding this comment.
The code shortly after this makes changes to the current_version of the addon, which, given the lazy evaluation of querysets, affects the result of promoted_group (namely, it loses access to the promotion).
There was a problem hiding this comment.
Is there a test covering this? Seems not since you could change the code without any failure. Please add a test for that behavior.
KevinMind
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Basic verification is passing for me. I'd like some better test instructions
- how to test for different types of badges
- how to verify results
- include before/after screenshots
Additionally I would like some more unit tests on the PromotedGroup model methods. Other than that looks good.
KevinMind
reviewed
Mar 25, 2025
KevinMind
reviewed
Mar 25, 2025
KevinMind
reviewed
Mar 25, 2025
chrstinalin
force-pushed
the
#15487-correct-approval-logic
branch
from
5867f73 to
2d31c11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15487
Description
Fixes the logic relating to retrieving approved promotions for an add-on.
Testing
Note: Expected promotions are in the promotedaddon admin.
/manage.py sync_promoted_addons.Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.