Skip to content

[Bug]: Healtcheck + completed workflows are broken in some edge case #15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
KevinMind opened this issue Mar 18, 2025 · 1 comment · Fixed by mozilla/addons-server#23190
Closed
1 task done

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Mar 18, 2025

What happened?

The workflow was run from the "schedule" event, but linked to a bunch of obscure Pull requests in different repositories https://api.github.com/repos/mozilla/addons-server/actions/runs/13907783652

  • The healthcheck Dev job failed due to an un-handled network error requests.exceptions.ConnectionError which prevented the blocks json file from being created
  • this lead the next step to fail before sending the slack message
  • the completed job ran correctly, but it had malformed data so sent a weird looking slack notification
Image

What did you expect to happen?

In this case we would expect the network error to be caught and handled, or that the completed job could run from a missing json file it seems to be sending incorrect data, maybe from running on a fork?

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@diox
Copy link
Member

diox commented Mar 18, 2025

Need to investigate whether or not the network error was retried. We probably should have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants