-
Notifications
You must be signed in to change notification settings - Fork 116
Deng 8901 add fail to gclid conversions bigeye check #7866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deng 8901 add fail to gclid conversions bigeye check #7866
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -8,7 +8,7 @@ tag_deployments: | |||
- column_selectors: | |||
- name: moz-fx-data-shared-prod.moz-fx-data-shared-prod.firefoxdotcom_derived.gclid_conversions_v1.* | |||
metrics: | |||
- saved_metric_id: composite_key_uniqueness_2_column | |||
- saved_metric_id: composite_key_uniqueness_2_column [fail] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would fail as there is no saved metric defined with that name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do I make sure that the check fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kik-kik , if this uniqueness check fails, does the job fail or do we just get a warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this composite_key_uniqueness_2_column
saved metric would not result in a failure, this would just cause an issue to be opened in Bigeye.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Integration report for "Merge branch 'main' into deng_8901_add_fail_to_gclid_conversions_bigeye_check"
|
Description
This PR adds [fail] tag to bigeye config. This code must fail if the gclid and activity composite key is not unique.
Related Tickets & Documents
Reviewer, please follow this checklist