fix(security): 2 improvements across 1 files - #9658
Open
tomaioo wants to merge 1 commit into
Open
Conversation
- Security: SQL Injection via String Formatting in BigQuery Queries - Security: SQL Injection via String Formatting in BigQuery Query (adspend_v1) Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 1 files
Problem
Severity:
High| File:sql/moz-fx-data-marketing-prod/iprospect/adspend_v1/query.py:L42Multiple files construct SQL queries using Python f-strings with user-provided or variable inputs, creating SQL injection vulnerabilities. In
sql/moz-fx-data-marketing-prod/iprospect/adspend_v1/query.py, theargs.dateparameter is directly interpolated into SQL. Inbigquery_etl/public_data/publish_public_data_views.py, table names are split and used in view SQL. Inbigquery_etl/glam/client_side_sampled_metrics.py,metric_types,app_name,channel, andosare interpolated into SQL without parameterization.Solution
Use BigQuery query parameters (ScalarQueryParameter) instead of string interpolation. For table names/identifiers that cannot be parameterized, implement strict validation against allowed patterns before interpolation.
Changes
sql/moz-fx-data-marketing-prod/iprospect/adspend_v1/query.py(modified)