Cannot set snsTopicArn to disabled in fxa-graphql-api

[jackyzy823]

Description

It is said

fxa/packages/fxa-graphql-api/src/config.ts

Line 284 in a50fcff

doc: 'Amazon SNS topic on which to send account event notifications. Set to "disabled" to turn off the notifier',

But actually:

fxa/libs/shared/notifier/src/lib/notifier.sns.provider.ts

Lines 15 to 22 in a50fcff

	export function setupSns(config: NotifierSnsConfig) {
	const endpoint = config.snsTopicEndpoint;
	const region = config.snsTopicArn.split(':')[3];
	return new SNS({
	region,
	endpoint,
	});
	}

I think this is copied from

fxa/packages/fxa-auth-server/config/index.ts

Line 639 in a50fcff

doc: 'Amazon SNS topic on which to send account event notifications. Set to "disabled" to turn off the notifier',

but it's implementation has consider the disabled condition.

fxa/packages/fxa-auth-server/lib/notifier.js

Lines 22 to 31 in a50fcff

	if (notifierSnsTopicArn !== 'disabled') {
	// Pull the region info out of the topic arn.
	// For some reason we need to pass this in explicitly.
	// Format is "arn:aws:sns:<region>:<other junk>"
	const region = notifierSnsTopicArn.split(':')[3];
	// This will pull in default credentials, region data etc
	// from the metadata service available to the instance.
	// It's magic, and it's awesome.
	sns = new AWS.SNS({ endpoint: notifierSnsTopicEndpoint, region: region });
	}

---

Also when snsTopicArn is disabled, error shouldn't be raised when snsTopicEndpoint is undefined

fxa/libs/shared/notifier/src/lib/notifier.service.ts

Lines 36 to 38 in a50fcff

	if (!config.snsTopicEndpoint) {
	throw new Error('Config error notifierSnsTopicEndpoint missing');
	}

┆Issue is synchronized with this Jira Task

[vpomerleau]

Thank you for the report! We discussed this issue during triage and have moved it into our Jira backlog. PRs for this are welcome, but it's not currently on our short-term roadmap.