Properly check validity of a session ID#1390
Closed
highpon wants to merge 1 commit intomozilla:mainfrom
Closed
Conversation
martinthomson
requested changes
Dec 5, 2022
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
Do you have a test (or tests) that can show how this change corrects a concrete issue?
Collaborator
|
@highpon would you have that test available or should this be closed? |
Collaborator
|
Making this a draft PR until it becomes reviewable again. |
Collaborator
|
@highpon do you intend to keep working on this? |
Collaborator
|
Closing this for lack of activity. Please feel free to reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue #1367
Changes