fix(server): enable regex crate unicode-perl feature#1714
Merged
larseggert merged 1 commit intomozilla:mainfrom Mar 6, 2024
Merged
fix(server): enable regex crate unicode-perl feature#1714larseggert merged 1 commit intomozilla:mainfrom
regex crate unicode-perl feature#1714larseggert merged 1 commit intomozilla:mainfrom
Conversation
Enable the `unicode-perl` feature flag on `regex` crate dependency in `neqo-server` crate. The following regex makes use of the feature: ``` rust Regex::new(r"GET +/(\S+)(?:\r)?\n").unwrap() ``` Without the feature, the QUIC Interop tests panic with: ``` server | thread 'main' panicked at neqo-server/src/old_https.rs:140:49: server | called `Result::unwrap()` on an `Err` value: Syntax( server | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ server | regex parse error: server | GET +/(\S+)(?:\r)?\n server | ^^ server | error: Unicode-aware Perl class not found (make sure the unicode-perl feature is enabled) server | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ server | ) ```
larseggert
approved these changes
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 120 120
Lines 37399 37399
=======================================
Hits 34775 34775
Misses 2624 2624 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Thanks @larseggert. Can you trigger the QNS workflow on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
unicode-perlfeature flag onregexcrate dependency inneqo-servercrate.The following regex makes use of the feature:
Without the feature, the QUIC Interop tests panic with:
I will prioritize #1682 more to make sure we catch these regressions before merge.