ci: Use samply to convert perf data for the Firefox profiler
#2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
+ Coverage 95.52% 95.53% +0.01%
==========================================
Files 115 115
Lines 37275 37275
Branches 37275 37275
==========================================
+ Hits 35607 35612 +5
+ Misses 1662 1659 -3
+ Partials 6 4 -2
|
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 37d76e8. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 24ba9d9. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [854.07 ms 886.17 ms 918.25 ms]
thrpt: [108.90 MiB/s 112.84 MiB/s 117.09 MiB/s]
change:
time: [-4.3357% +0.6967% +6.0625%] (p = 0.80 > 0.05)
thrpt: [-5.7159% -0.6919% +4.5322%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [353.33 ms 354.78 ms 356.25 ms]
thrpt: [28.070 Kelem/s 28.186 Kelem/s 28.302 Kelem/s]
change:
time: [-0.5705% -0.0118% +0.5513%] (p = 0.97 > 0.05)
thrpt: [-0.5483% +0.0118% +0.5738%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.897 ms 26.069 ms 26.247 ms]
thrpt: [38.099 elem/s 38.360 elem/s 38.614 elem/s]
change:
time: [-0.8443% +0.1671% +1.0996%] (p = 0.74 > 0.05)
thrpt: [-1.0877% -0.1668% +0.8514%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: 💔 Performance has regressed. time: [1.8247 s 1.8416 s 1.8604 s]
thrpt: [53.751 MiB/s 54.300 MiB/s 54.804 MiB/s]
change:
time: [+2.9566% +4.5044% +6.0413%] (p = 0.00 < 0.05)
thrpt: [-5.6971% -4.3102% -2.8717%]
decode 4096 bytes, mask ff: No change in performance detected. time: [12.093 µs 12.127 µs 12.168 µs]
change: [-0.3118% +0.1171% +0.5794%] (p = 0.64 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.9814 ms 2.9909 ms 3.0021 ms]
change: [-0.3511% +0.0912% +0.5500%] (p = 0.71 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.221 µs 20.273 µs 20.331 µs]
change: [-0.1285% +0.2960% +0.7661%] (p = 0.20 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.8370 ms 4.8484 ms 4.8613 ms]
change: [-0.3897% -0.0299% +0.3162%] (p = 0.88 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [6.3762 µs 6.4015 µs 6.4322 µs]
change: [-0.8742% -0.3176% +0.1653%] (p = 0.25 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [2.1740 ms 2.1812 ms 2.1897 ms]
change: [-0.3912% +0.1235% +0.6508%] (p = 0.66 > 0.05)
1000 streams of 1 bytes/multistream: Change within noise threshold. time: [25.598 ms 25.625 ms 25.653 ms]
change: [-0.4154% -0.2633% -0.1125%] (p = 0.00 < 0.05)
1000 streams of 1000 bytes/multistream: Change within noise threshold. time: [143.60 ms 143.63 ms 143.67 ms]
change: [+0.1801% +0.2153% +0.2504%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [95.647 ns 95.937 ns 96.229 ns]
change: [-0.6417% -0.0662% +0.6231%] (p = 0.84 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [113.95 ns 114.29 ns 114.67 ns]
change: [-0.0680% +0.4716% +1.0778%] (p = 0.09 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [113.60 ns 114.30 ns 115.10 ns]
change: [-0.0442% +0.7608% +1.8193%] (p = 0.10 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.867 ns 94.326 ns 94.857 ns]
change: [-1.0649% +0.2988% +1.6655%] (p = 0.68 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [117.89 ms 117.95 ms 118.01 ms]
change: [-0.7696% -0.6988% -0.6321%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [8.5578 µs 8.7766 µs 8.9838 µs]
change: [-3.3940% -0.0232% +3.0708%] (p = 0.99 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [35.412 ms 35.487 ms 35.562 ms]
change: [+0.1798% +0.4512% +0.7231%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [36.238 ms 36.333 ms 36.431 ms]
change: [+0.7606% +1.1673% +1.5405%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [35.575 ms 35.627 ms 35.680 ms]
change: [+0.2938% +0.5207% +0.7447%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [36.956 ms 37.024 ms 37.093 ms]
change: [-0.1009% +0.1381% +0.4039%] (p = 0.29 > 0.05)
Client/server transfer resultsPerformance differences relative to 24ba9d9. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
|
This is waiting for @mstange to add a |
larseggert
changed the title
samply to convert perf data for the Firefox profiler
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
|
I'd like to merge this now. I added a TODO to switch back to installing binaries once there is a new samply release. Could I get a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow finer-grained stack- and flamegraphs that show inlined functions. Also might lead to smaller artifact sizes.