Skip to content

Add regression test for PR 19825 #20110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maettuu
Copy link
Contributor

@maettuu maettuu commented Jul 20, 2025

This test was automatically generated and could serve as a regression test for PR #19825. The added test:

  • fails on the codebase prior to the PR
  • passes on the codebase after the PR
  • still passes against today’s pdf.js master branch

It verifies that 2×3 transformation matrices (translation, scale, shear) are applied in-place to multiple point pairs without creating subarrays.

This is part of our research at the ZEST group of University of Zurich in collaboration with Mozilla.
If you have any suggestions, questions, or simply want to learn more, feel free to contact us at [email protected] and [email protected].

@maettuu maettuu marked this pull request as draft July 23, 2025 14:22
@maettuu maettuu marked this pull request as ready for review July 23, 2025 16:40
@timvandermeij
Copy link
Contributor

Please make sure the commits are squashed; see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits.

@timvandermeij timvandermeij requested a review from calixteman July 29, 2025 18:10
Verify that 2×3 transformation matrices (translation, scale, shear) are applied in-place to multiple point pairs without creating subarrays.

See PR mozilla#19825
@maettuu maettuu force-pushed the reg-test-pr-19825 branch from 1bf88e1 to 4f349d8 Compare August 6, 2025 09:02
@calixteman
Copy link
Contributor

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9b212ce0b494966/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3048193bc77850a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/9b212ce0b494966/output.txt

Total script time: 60.00 mins

@calixteman
Copy link
Contributor

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0e9a3e2e423de83/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e6ba1460da45213/output.txt

} from "../../src/shared/util.js";
import { DOMMatrix, DOMPoint } from "@napi-rs/canvas";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cannot run because of this line.
Can you check it works for you locally in running gulp unittest ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants