-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add regression test for PR 19825 #20110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please make sure the commits are squashed; see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits. |
Verify that 2×3 transformation matrices (translation, scale, shear) are applied in-place to multiple point pairs without creating subarrays. See PR mozilla#19825
1bf88e1
to
4f349d8
Compare
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b212ce0b494966/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/3048193bc77850a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9b212ce0b494966/output.txt Total script time: 60.00 mins |
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0e9a3e2e423de83/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e6ba1460da45213/output.txt |
} from "../../src/shared/util.js"; | ||
import { DOMMatrix, DOMPoint } from "@napi-rs/canvas"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cannot run because of this line.
Can you check it works for you locally in running gulp unittest
?
This test was automatically generated and could serve as a regression test for PR #19825. The added test:
It verifies that 2×3 transformation matrices (translation, scale, shear) are applied in-place to multiple point pairs without creating subarrays.
This is part of our research at the ZEST group of University of Zurich in collaboration with Mozilla.
If you have any suggestions, questions, or simply want to learn more, feel free to contact us at [email protected] and [email protected].