Add regression test for PR 19184 #20151
Open
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verifies that ToUnicodeMap correctly maps Extension B characters to their full Unicode code points using codePointAt See PR mozilla#19184
| @@ -0,0 +1,34 @@ | |||
| /* Copyright 2022 Mozilla Foundation | |||
| const expected = 0x20000; // Unicode code point for the character | ||
| let actual; | ||
| toUnicodeMap.forEach((charCode, unicode) => { | ||
| if (charCode === "32") { |
There was a problem hiding this comment.
We could also use 0x20.toString() here to make it a little bit clearer where the value comes from and that it matches the key in the cmap variable. That'd also allow for removing the comment below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was automatically generated and could serve as a regression test for PR #19184. The added test:
It verifies that ToUnicodeMap correctly maps Extension B characters (surrogate pairs) to their full Unicode code points using codePointAt.
This is part of our research at the ZEST group of University of Zurich in collaboration with Mozilla.
If you have any suggestions, questions, or simply want to learn more, feel free to contact us at [email protected] and [email protected].