Skip to content

Fix: Add visible focus outlines for PDF viewer interactive elements #20162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pritgit28
Copy link

Screenshot 2025-08-12 at 12 53 52 AM Screenshot 2025-08-12 at 12 54 47 AM Screenshot 2025-08-12 at 1 16 21 AM

This change ensures that all interactive toolbar elements in the PDF viewer display a visible focus outline when navigated via keyboard.
Previously, the focus ring skipped certain elements, making them inaccessible through keyboard navigation.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this patch passes linting.

@timvandermeij timvandermeij removed the request for review from calixteman August 12, 2025 18:06
@timvandermeij timvandermeij requested review from calixteman and removed request for timvandermeij August 14, 2025 18:24
@pritgit28 pritgit28 marked this pull request as draft August 14, 2025 22:56
@pritgit28
Copy link
Author

@timvandermeij I'm so sorry, I accidentally clicked on something that sent you a review request once again. My apologies.

@pritgit28 pritgit28 marked this pull request as ready for review August 14, 2025 23:01
@timvandermeij timvandermeij removed their request for review August 15, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants