Skip to content

Remove all mixins supporting vendor prefixes (Fix #957) #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Mar 20, 2025

⚠️ DO NOT MERGE ⚠️ Let's save this one for a major breaking version release

Description

This version removes mixins which added vendor-prefixes. Browser support for these is now excellent.

  • I have recorded this change in CHANGELOG.md.

Issue

Fix #957

Testing

View the affected components to make sure they are still displaying properly.

@stephaniehobson stephaniehobson force-pushed the vendor branch 2 times, most recently from 559b65b to e535cd3 Compare March 20, 2025 23:31
Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟 Love it!

Unfortunately I can't seem to identify the mzp-a-fade-* build issue just from glancing it, pretty sure it's all in the correct order… 🤷

Some copy/formatting nits in the meantime:

@stephaniehobson
Copy link
Contributor Author

I'm pretty sure the mzp-a-fade-* build issue has turned up because I'm actually declaring an animation in the code now - instead of what we were doing before which was use an include that was not being evaluated for validity. So, a nice side affect of the change is better linting! The downside is I think we have to disable the rule since Stylelint doesn't evaluate Sass includes/use rules.

Stephanie Hobson added 2 commits May 14, 2025 21:23
This version removes mixins which added vendor-prefixes. Browser support for these is now excellent.

- One migration path is to edit your code to use the unprefixed versions.
- Another option is to move these utility mixins into your own code base (though, be aware they are
  no longer used in Protocol and this will not give you backwards compatible Protocol components).
- If you need that level of vendor prefix support consider adding a tool such as
  [autoprefixer](https://github.com/postcss/autoprefixer) to your code base.
- Affected mixins are:
  - `animation`
  - `appearance`
  - `background-size`
  - `box-decoration-break`
  - `box-sizing`
  - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-itmes`, `justify-content,`
  - `transform`, `transform-origin`, `transform-style`
  - `transition`, `transition-property`, `transition-duration`, `transition-delay`
@maureenlholland
Copy link
Collaborator

Do Not Merge until Icon release is published

@stephaniehobson stephaniehobson mentioned this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit use of vendor prefix mixins
3 participants