-
Notifications
You must be signed in to change notification settings - Fork 81
Remove all mixins supporting vendor prefixes (Fix #957) #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
559b65b
to
e535cd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💟 Love it!
Unfortunately I can't seem to identify the mzp-a-fade-*
build issue just from glancing it, pretty sure it's all in the correct order… 🤷
Some copy/formatting nits in the meantime:
I'm pretty sure the |
This version removes mixins which added vendor-prefixes. Browser support for these is now excellent. - One migration path is to edit your code to use the unprefixed versions. - Another option is to move these utility mixins into your own code base (though, be aware they are no longer used in Protocol and this will not give you backwards compatible Protocol components). - If you need that level of vendor prefix support consider adding a tool such as [autoprefixer](https://github.com/postcss/autoprefixer) to your code base. - Affected mixins are: - `animation` - `appearance` - `background-size` - `box-decoration-break` - `box-sizing` - `flexbox`, `flex`, `flex-direction`, `flex-wrap`, `align-itmes`, `justify-content,` - `transform`, `transform-origin`, `transform-style` - `transition`, `transition-property`, `transition-duration`, `transition-delay`
Do Not Merge until Icon release is published |
Description
This version removes mixins which added vendor-prefixes. Browser support for these is now excellent.
CHANGELOG.md
.Issue
Fix #957
Testing
View the affected components to make sure they are still displaying properly.