Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the first commit of this work, I searched the repo for
@supports (css: variables)
, and refactored those selectors away by replacing the SASS variables in the main selector with their preexisting native CSS equivalent.Once that was done, I combed through the repo for examples of those SASS variables to make sure I got them all. there were a few that didn't have
@supports
flags, so I just replaced a handful like this:$v-grid-md
-->var(--v-grid-md)
Finally, I removed all of the SASS variables for grid sizing, font families, and colors. They had all already just been used as duplicate fallbacks for CSS variables, so I'm confident that as long as the SASS compiles, then everything should be consistent.
CHANGELOG.md
.Issue
982
Testing
Everything compiles, and I gave the app a pretty thorough visual pass compared to the main branch. I'm pretty sure it's all good... but it could benefit from another set of eyes.