-
Notifications
You must be signed in to change notification settings - Fork 603
feat: Add axum impl for dist server #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2464 +/- ##
==========================================
- Coverage 71.22% 69.72% -1.50%
==========================================
Files 64 72 +8
Lines 35221 36625 +1404
==========================================
+ Hits 25087 25538 +451
- Misses 10134 11087 +953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
|
did you evaluate any of the wins here ? thanks |
The ultimate goal is to remove the dying After the whole refactor been done, we can expected:
We haven't discussed the full plan yet, but I expect the axum impl will become the default after several versions and finally we'll remove the rouille impl. |
|
ok, thanks |
Sorry, I didn’t. I’m working on macOS now and don’t have access to a Linux server. I wish we could get some feedback from the community. |
Close #2234
This PR adds an Axum implementation for the dist server. We introduced this as a new feature called
dist-server-axumwith no functional changes to the existing server. This allows our community to test the new server as an experimental option.All behavior remains identical, and all configurations are unchanged. You can run this server exactly as before by simply replacing the binary.
We welcome your feedback and trials. This is just the first step toward modernizing sccache, with the goal of making it a fully async, modular, and easier-to-maintain project.
This PR was primarily authored with Amp using Claude-Sonnet-4.5 and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.