Skip to content

Conversation

@djdv
Copy link

@djdv djdv commented Oct 21, 2025

I'm running the unstable version of everything, from the OS up to the Rust compiler.
In this environment I can no longer build/install sccache.
I haven't bisected when this stopped working but it seems to be tied to the windows-sys dependency

> cargo install --path=.

...

Compiling sccache v0.12.0 (C:\Users\Dominic Della Valle\Projects\3P\Rust\sccache)
error[E0432]: unresolved import `windows_sys::Win32::System::Threading::CreateProcessW`
   --> src\commands.rs:186:81
    |
186 |         CREATE_NEW_PROCESS_GROUP, CREATE_NO_WINDOW, CREATE_UNICODE_ENVIRONMENT, CreateProcessW,
    |                                                                                 ^^^^^^^^^^^^^^ no `CreateProcessW` in `Win32::System::Threading`

warning: use of deprecated method `tempfile::TempDir::into_path`: use TempDir::keep()
   --> src\compiler\nvcc.rs:389:10
    |
389 |         .into_path();
    |          ^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

For more information about this error, try `rustc --explain E0432`.
warning: `sccache` (lib) generated 1 warning
error: could not compile `sccache` (lib) due to 1 previous error; 1 warning emitted
warning: build failed, waiting for other jobs to finish...
error: failed to compile `sccache v0.12.0 (C:\Users\Dominic Della Valle\Projects\3P\Rust\sccache)`, intermediate artifacts can be found at `C:\Users\Dominic Della Valle\Projects\3P\Rust\sccache\target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Updating it, and adapting the source code to match the API change seems to fix it.
The only change is related to using an explicitly typed null pointer versus an implicit pointer of integer 0.
Assuming this works fine on stable, but I'm sure the CI will let us know.

Specifically I did this:
cargo update --verbose --breaking -Z unstable-options -p windows-sys
And then edited src\commands.rs to conform to the breaking changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.71%. Comparing base (de9895c) to head (4107144).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
- Coverage   71.23%   70.71%   -0.52%     
==========================================
  Files          64       64              
  Lines       35221    34575     -646     
==========================================
- Hits        25088    24451     -637     
+ Misses      10133    10124       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djdv
Copy link
Author

djdv commented Oct 22, 2025




Oh boy....

I'll check the style rules. Assuming the toml must be single line like it was before.

Curious that the tests are failing with the same problem AFTER applying the patch.
I'll look at this later but not confident I'll be able to find the root of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants