askama 0.13->0.14. Significant as all filter function signatures change. #2621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All filter functions now take at least 2 args; the new 2nd arg is now typically `_: &dyn askama::Values`.
|
They increased the MSRV to Rust 1.83.0 in that release: askama-rs/askama@04a4d5b m-c is at 1.82.0 for now: https://searchfox.org/mozilla-central/rev/67ff378efd69fbfb26d47ee4d9d0d249ab4be1d5/Cargo.toml#62-63 That might change by the time we get an UniFFI update into m-c, but would be a blocker for now. |
Closed
|
Hi folks, any updates on an ETA for this getting merged? |
|
I just checked the status in moz-central and it looks like they're working to bump the MSRV version right now. I'd expect a fix in the next few weeks, but it's hard to estimate. My guess is that we'll release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All filter functions now take at least 2 args; the new 2nd arg is now typically
_: &dyn askama::Values. Theaskama::Valuesconcept seems good in general.@badboy @bendk this is going to be a little painful, but I guess we have to take this eventually so uniffi .30 seems like it should be fine? We'll probably need to upgrade nimbis-fml at the same time.