Added reverse mapping implementation to LabelMap #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mphoward
requested changes
Nov 19, 2025
Contributor
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks very much for the quick, nice contribution! I have a couple suggestions that I recommend we apply. Could you also please add your name to doc/source/credits.rst in alphabetical order?
type hint usage Co-authored-by: Michael Howard <[email protected]>
Co-authored-by: Michael Howard <[email protected]>
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Contributor
Author
|
And that should be everything! I wasn't sure if C. was just an initial or if it stood for contributor, so I just put myself at the bottom. |
mphoward
approved these changes
Nov 19, 2025
Contributor
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thank you! C. is an initial for that contributor. I'll make sure your name is in the right spot before merging. Thanks again!
Contributor
|
@clpetix if you get a chance, could you update the ethanol–water tutorial to use this inverse mapping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101 implementing the changes that were discussed, including unit tests.