Automatically center box when converting to GSD. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is made of box data instead of reference.
mphoward
reviewed
May 29, 2025
Contributor
Author
|
We had another bug floating around our conversion from_hoomd_gsd. We had previously set I think I've ironed out all the problems with how the conversions work and have checked both orthorhombic and triclinic boxes look correct in Ovito going both directions. @mphoward, please let me know if you see anything else that needs tweaked here! |
mphoward
reviewed
Jun 3, 2025
…eature/hoomd-center-box
…der has_particles.
Contributor
Author
|
@mphoward, I've applied the suggested edits! This should be ready for you to take another look! |
mphoward
approved these changes
Jun 4, 2025
Contributor
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks! Two small suggestions to simplify the code, then this looks good to me.
Contributor
Author
|
I've made those two changes, so this should be good to go! |
mphoward
approved these changes
Jun 4, 2025
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to automatically center box for conversion to GSD rather than raise an error.
Additionally, this fixes a bug where tilts were not being converted to HOOMD-blue's convention in
to_hoomd_gsd(). I believe this error went unnoticed in our unit tests because we were creating a reference to the tilt data infrom_hoomd_gsd()rather than a copy.