Skip to content

Conversation

@mayukh33
Copy link
Contributor

@mayukh33 mayukh33 commented Apr 9, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://mphowardlab.github.io/preview/pr-48/

Built to branch gh-pages at 2025-04-10 14:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@clpetix
Copy link
Contributor

clpetix commented Apr 9, 2025

@mphoward, we've updated the photos here. Please have a look and let us know what you think.

This addresses part 2 & 4 of Issue #47.

Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These changes look good to me. Just one question: do you want to delete the old photos? From the repository's perspective, it doesn't save any space because the image still needs to be stored to be able to roll back to older commits. So, you might revert the deletions of the jpg files... I think the changes in the yml file should be sufficient to update the slideshow.

Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mphoward mphoward merged commit 5ef6fa9 into main Apr 10, 2025
2 checks passed
@mphoward mphoward deleted the people/photos branch April 10, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants