Fix writing GSD images. #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! Can we add some short unit test that checks this? |
Contributor
Author
|
@mphoward, do you have any insights on why this added tests would cause the HOOMD 2 version to fail? |
Collaborator
|
I am not sure why this would fail in HOOMD 2. It is writing images out that are not just zeros, but they don't seem to be the right ones. Maybe try writing the GSD files with high frequency and watch the movies (HOOMD 2 vs. 4) to see if you spot a difference. If it is some quirk of HOOMD 2, I move to drop it sooner rather than later. |
Contributor
Author
|
Thanks! I'll try that and see, but I am in favor of dropping support for HOOMD 2 pretty soon. |
Contributor
Author
|
@mphoward, dropping HOOMD 2 fixed these failing tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #278.