Fix failing errors regarding lammpsio box. #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mphoward
approved these changes
Aug 27, 2025
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Makes sense to me! Do we know if something changed in lammpsio to trigger this?
Contributor
Author
|
I don't see any change in lammpsio that should have caused this. This should have always been an error since lammpsio's Snapshot doesn't have a high or low attribute. The blame shows this has been here for two years though, so I'm not sure why it never triggered before |
Collaborator
|
Hmm, maybe some change in another dependency has caused this branch to trip now then... will merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the errors first seen in PR #306.