Skip to content

Conversation

@ivastar
Copy link
Contributor

@ivastar ivastar commented Feb 7, 2024

Creating a branch with static versioning.

@ivastar
Copy link
Contributor Author

ivastar commented Feb 7, 2024

@jdavies-st is this all that is needed to undo the dynamic versioning?

Copy link
Collaborator

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You'll also want to remove setuptools_scm as a build dependency under [build-system] requires in pyproject.toml.

And a minor nit below to not use bare excepts in try/except blocks.

@jdavies-st
Copy link
Collaborator

Oh, and I tested these changes on the package I made from the template last Friday, and it works like a charm. 🚀

@ivastar
Copy link
Contributor Author

ivastar commented Feb 12, 2024

@jdavies-st is this better?

@jdavies-st
Copy link
Collaborator

Add a blank line before [project.urls] in pyproject.toml and a blank line at the end of __init__.py then you're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants