[RFC] input.conf: duplicate some keybind to keypad siblings

[kasper93]

They still can be remapped individually by users, but let's duplicate them by default.

Same as 8c6ad1d.
Fixes: #15993

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32
• mpv-x86_64-windows-msvc

macOS

• mpv-macos-13-intel
• mpv-macos-14-arm
• mpv-macos-15-arm

[zhongfly]

How about KP_ENTER keypress ENTER ?

[kasper93]

how about KP_ENTER keypress ENTER ?

Hmm, maybe. Not sure what looks better if you read this file or something like stats.lua.

[kasper93]

@na-na-hi thoughts?

[zhongfly]

keypress does not work for keys bound to repeatable commands.
Example: KP_MULTIPLY keypress * does not work like KP_MULTIPLY add volume 2, only add volume 2 once.

Is it possible to add a flag for keypress so that one key can be exactly equivalent to another?

[na-na-hi]

keypress has the repeatability problem. Default repeatability depends on the command, and keypress is not repeatable by default, so it's wrong if the command on the mapped key is repeatable. If you force it with the repeatable prefix, it would behave wrong if the command on the mapped key is not repeatable.

Also keypress only sends the press event but not the down/up/repeat event, so when a script uses mp.add_key_binding it cannot know which state the key is in, so it behaves differently from real keypresses.

[kasper93]

So, I don't know what to do here. I don't want to manually duplicate everything. It pollutes input config. And doing this in core would probably be even worse. We could add some sort of aliasing mechanism, but it seems too much for this case alone.

[eNV25]

The default behavior of keypress could changed so that it's repeatable if possible, else normal i.e. no error. The repeatable and nonrepeatable can be used to control it if needed.

[eNV25]

For the keypad arrow keys repeatable keypress is the only one that works, since many scripts (like console.lua, etc.) add bindings to the normal arrow keys dynamically.

[kasper93]

changed it back to using commands directly.

[hooke007]

Q: Is it possible to improve the syntax?

For instance:

RIGHT   seek 5
DOWN   seek 5
KP_RIGHT   seek 5
KP_DOWN   seek 5
d   seek 5
s   seek 5
k   seek 5
j   seek 5

Use the de-duplicated solutions:

RIGHT,DOWN,KP_RIGHT,KP_DOWN,d,s,k,j   seek 5

[kasper93]

It's probably possible, but not sure the cosmetic gain is enough to justify to parser change. Though it shouldn't be a big one.

[eNV25]

This doesn't actually fix the linked issue completely, since it doesn't touch console.lua and other built-in scripts.