mac/window: rewrite calculateWindowPosition function with easing function #16027
+80
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelxk
force-pushed
the
rewrite-mac-func
branch
from
6776534 to
8934124
Compare
|
Download the artifacts for this pull request: |
|
the request in #13608 is meant to simplify this function and not add another layer of complexity to it. so in general i am a bit hesitant to accept such changes. it would also probably help if you could explain what you want to accomplish. also tested this really quick and this change already adds some regressions. just toggling fs (to and from) moves the window to the bottoms left, till it reaches the bottom left corner. this function is meant to be noop if size, position, screen, etc didn't change. |
|
Commits needs to be squashed and commit description should explain what those changes fixes and the reasoning behind the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #13608
add a easing function for
calculateWindowPositionfunction