Skip to content

player/command: update speed filters for pitch-correction change too #16948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

player/command: update speed filters for pitch-correction change too #16948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a6798
player/video: only set a/v speed factor to 1 when exiting display-sync
llyyr Oct 23, 2025
878dfa2
player/command: update speed filters for pitch-correction change too
llyyr Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion player/command.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8027,7 +8027,8 @@ void mp_option_run_callback(struct MPContext *mpctx, struct mp_option_callback *
run_command_opts(mpctx);
}

if (opt_ptr == &opts->playback_speed || opt_ptr == &opts->playback_pitch) {
if (opt_ptr == &opts->playback_speed || opt_ptr == &opts->playback_pitch ||
opt_ptr == &opts->pitch_correction) {
update_playback_speed(mpctx);
mp_wakeup_core(mpctx);
}
Expand Down
8 changes: 5 additions & 3 deletions player/video.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,9 +955,11 @@ static void schedule_frame(struct MPContext *mpctx, struct vo_frame *frame)
}

if (!mpctx->display_sync_active) {
mpctx->speed_factor_a = 1.0;
mpctx->speed_factor_v = 1.0;
update_playback_speed(mpctx);
if (mpctx->past_frames[1].num_vsyncs >= 0) {
mpctx->speed_factor_a = 1.0;
mpctx->speed_factor_v = 1.0;
update_playback_speed(mpctx);
}

update_av_diff(mpctx, mpctx->time_frame > 0 ?
mpctx->time_frame * mpctx->video_speed : 0);
Expand Down
Loading