mac/vulkan: log certain important metal layer states #17024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we have a mapping layer between vulkan and metal (MoltenVK) we don't actually know which pixel format is used/mapped to. log pixel format changes to actually see which format was chosen. only those 9 formats are valid for a CAMetalLayer. https://developer.apple.com/documentation/quartzcore/cametallayer/pixelformat
Akemi
force-pushed
the
mac_layer_logging
branch
2 times, most recently
from
7c4b3c0 to
a777004
Compare
|
Download the artifacts for this pull request: Windows |
since we have a mapping layer between vulkan and metal (MoltenVK) we don't actually know which colorspace is used/mapped to. log colorspace changes to actually see which colorspace was chosen.
since we have a mapping layer between vulkan and metal (MoltenVK) we don't actually know which EDR data is used/mapped to. log EDR data changes to actually see which EDR data was chosen.
since we have a mapping layer between vulkan and metal (MoltenVK) we don't actually know when HDR is activated log HDR active state.
since we have a mapping layer between vulkan and metal (MoltenVK) we don't actually know when display sync is activated log display sync active state.
since we have a mapping layer between vulkan and metal (MoltenVK) we don't actually know when the layer is opaque and direct-to-display is possible. log opaque state.
Akemi
force-pushed
the
mac_layer_logging
branch
from
a777004 to
69ce287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes debugging and finding problems easier. since we have a vulkan to metal mapping layer (MoltenVK, mesa, any kind of vulkan macOS driver) we don't actually know what is set or if it is properly set/mapped.
actually log the important metal layer states to be sure everything is properly set up.
only the 9 allowed pixel formats(https://developer.apple.com/documentation/quartzcore/cametallayer/pixelformat) on the metal layer were actually mapped with a name in the enum extension. without the mapping it would only print a plain int value.
for the colorspace i did some string manipulation to get an actual name/description and the corresponding swift constant name instead of the convoluted obj-c representations, example: