loadfile: clip long track titles #17037
Conversation
|
Note that track metadata comes after URLs so that will get clipped too. Not sure if that is worth it or the issue should be a wontfix. |
|
I haven't read the previous PRs closely, but wouldn't it be better if we stripped the parameters from URL filenames? The current behavior for an URL like edit: disregard this, it fails if the url is instead |
guidocella
changed the title
guidocella
force-pushed
the
track-clip
branch
from
378fbc7 to
58d937b
Compare
|
Actually I don't think track lines necessarily have to fit exactly on 1 line. Changed it to just clip track titles longer than 99 characters. |
guidocella
force-pushed
the
track-clip
branch
from
58d937b to
8447aae
Compare
When a track title is taken from its filename and is very long, clip it to not make track information too verbose. term_disp_width() is convenient even for ASS output because it avoids cutting in the middle of UTF-8 characters. Fixes mpv-player#10975 along with mpv-player#17021.
guidocella
force-pushed
the
track-clip
branch
from
8447aae to
449715b
Compare
|
I just checked...I have many tracks that are close to 200 characters or more...I think many OS's do a fine job of limiting it to 255 or so. I just have a tooltip to show entire track name in uosc. Useful when fuzzy searching for particular terms otherwise user wouldn't be able to see certain matches. Does this patch just clip tracks for the built-in mpv playlist..if so no big deal. |
|
No, the track title itself is clipped. Which is also useful to not hide metadata in the track menu. |
|
Are you confusing tracks and playlist items? External track titles are usually just something like "en.srt". |
3 participants
When a track information is longer than the terminal width, clip it and add ellipsis. Useful for long URLs.
Fixes #10975 along with #17021.