test(batch): add push/delete and media upload tests; docs/CI updates#18
Merged
mrMaxwellTheCat merged 2 commits intomainfrom Feb 8, 2026
Merged
test(batch): add push/delete and media upload tests; docs/CI updates#18mrMaxwellTheCat merged 2 commits intomainfrom
mrMaxwellTheCat merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR strengthens the CLI’s batch workflow validation by adding tests around batch-build push/delete behavior (including media upload and push failures), and updates documentation to standardize contributor commands on just. It also tidies the exceptions module exports.
Changes:
- Add batch-build tests covering
--push,--delete-after, media upload, and push-failure retention behavior. - Standardize contributor/release docs to use
justcommands (e.g.,just all,just test,just lint). - Normalize
core.exceptionsmodule docstring and exported symbols via__all__.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_cli_batch.py | Adds coverage for batch-build push/delete/media behaviors using monkeypatched AnkiConnector methods. |
| src/anki_yaml_tool/core/exceptions.py | Updates module docstring and defines __all__ for consistent exception exports. |
| docs/VERSIONING.md | Updates release checklist commands from make to just. |
| docs/DOCUMENTATION_ORGANIZATION.md | Updates pre-commit workflow guidance to use just all. |
| CONTRIBUTING.md | Updates contributor workflow snippets to use just commands. |
| .vscode/tasks.json | Removes VSCode task definitions from the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for batch-build push/delete behavior (including media upload and push failure cases), updates docs to standardize on 'just' and documents batch CLI status, and normalizes exceptions exports. All tests and quality checks pass locally (just all).\n\nChanges: \n- Add tests: ests/test_cli_batch.py\n- Update docs: README.md, CONTRIBUTING.md, ROADMAP.md, docs/*\n- Fix: src/anki_yaml_tool/core/exceptions.py (docstring and all)\n\nAll checks: ruff, mypy, pytest (173 tests) pass and coverage is above threshold.\n